How we handle patches (mmoved): Difference between revisions
Content added Content deleted
imported>Paulproteus No edit summary |
imported>Jesstess No edit summary |
||
| Line 1: | Line 1: | ||
{{Hacking OpenHatch}} |
|||
== As a patch submitter == |
== As a patch submitter == |
||
| Line 9: | Line 11: | ||
== As a patch reviewer == |
== As a patch reviewer == |
||
* Ping the author on IRC (or something) to see if she's/he's uploaded the most recent version. |
* Ping the author on IRC (or something) to see if she's/he's uploaded the most recent version. |
||
* Ask the author roughly this question: "Please email devel@lists.openhatch.org saying that you're okay with your work being under AGPLv3. If you're willing, it'd be nice if you say 'the Affero GPL, version 3 or later, at your option'." |
* Ask the author roughly this question: "Please email devel@lists.openhatch.org saying that you're okay with your work being under AGPLv3. If you're willing, it'd be nice if you say 'the Affero GPL, version 3 or later, at your option'." |
||
Revision as of 19:33, 19 March 2011
This is a page about improving or modifying OpenHatch.
We call that "Hacking OpenHatch," and there is a whole category of pages about that.
As a patch submitter
- File a bug on https://openhatch.org/bugs/ with a link to your code (for example, a git repository somewhere on the Internet, or with patch files as attachments in bug itself.)
- If you opt for using git (which we recommend), please read https://github.com/diaspora/diaspora/wiki/Git-Workflow first
- If you generate patches and attach them, please do a few local commits and create the patch series with "git format-patch". (Read about How to generate patches with git format-patch)
- Make sure your patch is of good quality. Write unit tests, use PyChecker and pep8 tools; use comments and docstrings to explain things when necessary
- Join IRC and ping someone with deployment access (e.g., paulproteus) until it gets reviewed
- If it passes review, it should get deployed immediately.
As a patch reviewer
- Ping the author on IRC (or something) to see if she's/he's uploaded the most recent version.
- Ask the author roughly this question: "Please email devel@lists.openhatch.org saying that you're okay with your work being under AGPLv3. If you're willing, it'd be nice if you say 'the Affero GPL, version 3 or later, at your option'."