How we handle patches (mmoved): Difference between revisions

Content added Content deleted
imported>Paulproteus
imported>Jessica
m (Added link to Affero license and nmoved "Permit us" above submission)
Line 15: Line 15:
# Before creating the patch, update the master branch of your local repository checkout, and make sure your commits apply cleanly on top of master. In git, you can achieve this by developing on a branch and rebasing your branch commits on top of master.
# Before creating the patch, update the master branch of your local repository checkout, and make sure your commits apply cleanly on top of master. In git, you can achieve this by developing on a branch and rebasing your branch commits on top of master.
# Generate the patch set for your changes. Our preferred patch submission form is a patch series generated with "git format-patch". Read about [[How to generate patches with git format-patch]].
# Generate the patch set for your changes. Our preferred patch submission form is a patch series generated with "git format-patch". Read about [[How to generate patches with git format-patch]].

=== Permit us to share your work: ===

# Join our Devel email list by entering your email address into the form at http://lists.openhatch.org/mailman/listinfo/devel
# Send an email to devel@lists.openhatch.org saying that you're okay with your work being under the [http://www.gnu.org/licenses/index.html#AGPL Affero GPL, version 3]. If you're willing, it is preferable that you say 'the Affero GPL, version 3 or later, at your option'.


=== Submitting your patch series for review: ===
=== Submitting your patch series for review: ===
Line 24: Line 29:
If the reviewer says it's ready to go, your patch set will get deployed in short order. If the reviewer has feedback he/she wants addressed, make the necessary revisions and start back at the "Before creating a patch series" section.
If the reviewer says it's ready to go, your patch set will get deployed in short order. If the reviewer has feedback he/she wants addressed, make the necessary revisions and start back at the "Before creating a patch series" section.


=== Permit us to share your work: ===

# Join our Devel email list by entering your email address into the form at http://lists.openhatch.org/mailman/listinfo/devel
# Send an email to devel@lists.openhatch.org saying that you're okay with your work being under the Affero GPL, version 3. If you're willing, it is preferable that you say 'the Affero GPL, version 3 or later, at your option'.


== As a patch reviewer ==
== As a patch reviewer ==