Open Source Comes to Campus/Newcomer Tasks/Issue Tracker Cleaning: Difference between revisions

 
Line 85:
 
<blockquote>
jesstess, thanks for your patch and tests! The docstring for parse_request needs to be updated as part of this change.
 
Other than that, the patch looks correct from my inspection, and applies cleanly. I verified that with the patch applied, the reproducer no longer raises a ValueError and instead prints 42 as expected. make patchcheck also reports no errors, and the test_httplib tests still pass. I confirmed that the tests for parsing unicode strings that were added in this patch exercise the bug, as they fail with the code changes reverted and pass with the full patch applied.
 
The implementation looks straight-forward to me, although I'm not sure why you chose to separate your changes out into a new function. Can you explain your reasoning?</blockquote>
Anonymous user