Triaging Python tickets: Difference between revisions

← Older edit

Triaging Python tickets (view source)

Revision as of 17:36, 20 March 2014

164 bytes added , 10 years ago

Undo revision 17690 by 117.239.152.85 (talk)

Anonymous user

imported>Semenko

Revision as of 19:17, 18 March 2014 (view source) imported>Jesstess No edit summary ← Older edit		Latest revision as of 17:36, 20 March 2014 (view source) imported>Semenko (Undo revision 17690 by 117.239.152.85 (talk))
(5 intermediate revisions by 2 users not shown)
Line 1: Welcome! This page contains instructions for triaging Python tickets, which is something anyone can do and is a great way to get started with contributing to Python. This page ~~focus~~focuses on 3 types of triage: verifying bugs, reviewing patches, and reviewing documentation patches. [[File:Python_logo.png\|200px]] [[File:Bug.png\|200px]] Line 7: == Overview == [http://docs.python.org/devguide/triaging.html This section of the CPython developer guide] details triaging tickets. Please note that any registered user can comment on a ticket, but one must have "Developer" rights on the [http://bugs.python.org/ issue tracker] to update certain ticket fields. If you don't have Developer rights, don't worry! Leave detailed comments on a ticket, and everyone on the [http://docs.python.org/devguide/triaging.html#nosy-list nosy list] will get an email. With your triage comments, you've greatly increased the chance that someone ~~who can update the fields~~ will ~~review your comments and~~ move the ticket forward. Also, if you do this for a while, you'll get Developer rights so you can make the ticket field changes yourself! Line 64: ## If the patch includes tests, verify that the tests fail with the code changes reverted. # Does [http://docs.python.org/devguide/patch.html#generation make patchcheck] pass? # Is the patch accompanied by [http://docs.python.org/devguide/runtests.html new tests] that either exercise the bug or the new functionality? # Do the tests impacted by the patch still pass? (The committer will run the whole test suite, but you can [http://docs.python.org/devguide/runtests.html#runtests run just the relevant tests]) # If functionality was added or changed, is the patch accompanied by new or updated [http://docs.python.org/devguide/documenting.html documentation]? ~~In most cases, code changes must be accompanied by tests before they will get merged.~~ === Example patch review === Line 73: jesstess, thanks for your patch and tests!<br /> <br /> The docstring for <code>parse_request</code> needs to be updated as part of this ~~changes~~change.<br /> <br /> Other than that, the patch looks correct from my inspection, applies cleanly, and implements a straightforward solution.<br />