Triaging Python tickets: Difference between revisions
Content added Content deleted
imported>Jesstess No edit summary |
imported>Jesstess No edit summary |
||
| Line 14: | Line 14: | ||
== Verifying bugs == |
== Verifying bugs == |
||
[[File:Debugging.png|100px]] |
|||
Often, someone will report a bug, but nobody will want to work on a patch for it until the bug is confirmed. Thus, confirming a bug is a big step towards getting it fixed. |
Often, someone will report a bug, but nobody will want to work on a patch for it until the bug is confirmed. Thus, confirming a bug is a big step towards getting it fixed. |
||
| Line 45: | Line 47: | ||
I've attached a short script as a reproducer. The expected output is for it to print <code>42</code>, but it raises a <code>ValueError</code>. |
I've attached a short script as a reproducer. The expected output is for it to print <code>42</code>, but it raises a <code>ValueError</code>. |
||
</blockquote> |
</blockquote> |
||
== Reviewing patches == |
== Reviewing patches == |
||
[[File:Patch.png|100px]] |
|||
CPython committers are really busy, and they won't typically try to merge a patch until someone else has reviewed it. Thus, reviewing a patch is a big step towards getting it merged. |
CPython committers are really busy, and they won't typically try to merge a patch until someone else has reviewed it. Thus, reviewing a patch is a big step towards getting it merged. |
||
| Line 77: | Line 82: | ||
After the docstring is updated, I think this is ready for a commit review! |
After the docstring is updated, I think this is ready for a commit review! |
||
</blockquote> |
</blockquote> |
||
== Reviewing documentation patches == |
== Reviewing documentation patches == |
||
[[File:History.png|100px]] |
|||
Documentation patches have some different steps from code patches. They don't generally require accompanying tests, and they should be inspected visually for correctness. |
Documentation patches have some different steps from code patches. They don't generally require accompanying tests, and they should be inspected visually for correctness. |
||
| Line 99: | Line 107: | ||
The docs build cleanly with the patch. I visually inspected the changes in the built HTML docs and they look good. I also ran the modified example code from the docs and confirmed that it runs as expected. |
The docs build cleanly with the patch. I visually inspected the changes in the built HTML docs and they look good. I also ran the modified example code from the docs and confirmed that it runs as expected. |
||
</blockquote> |
</blockquote> |
||
== Finding tickets to triage == |
== Finding tickets to triage == |
||