Triaging Python tickets: Difference between revisions
Content added Content deleted
imported>Jesstess No edit summary |
imported>Jesstess No edit summary |
||
| Line 65: | Line 65: | ||
# Does [http://docs.python.org/devguide/patch.html#generation make patchcheck] pass? |
# Does [http://docs.python.org/devguide/patch.html#generation make patchcheck] pass? |
||
# Do the tests impacted by the patch still pass? (The committer will run the whole test suite, but you can [http://docs.python.org/devguide/runtests.html#runtests run just the relevant tests]) |
# Do the tests impacted by the patch still pass? (The committer will run the whole test suite, but you can [http://docs.python.org/devguide/runtests.html#runtests run just the relevant tests]) |
||
# Is the patch accompanied by new tests that either exercise the bug or the new functionality? |
|||
In most cases, code changes must be accompanied by tests before they will get merged. |
|||
=== Example patch review === |
=== Example patch review === |
||