Anonymous user
Triaging Python tickets: Difference between revisions
no edit summary
imported>Jesstess No edit summary |
imported>Jesstess No edit summary |
||
Line 50:
In most cases, code changes must be accompanied by tests before they will get merged.
== Reviewing documentation patches ==
Documentation patches have some different steps from code patches. They don't generally require accompanying tests, and they should be inspected visually for correctness.
=== Documentation patch review checklist ===
In your review, answer these questions:
# Does the patch apply cleanly?
# Is the documentation change correct, succinct, spelling error free, and grammatically correct?
# Does [http://docs.python.org/devguide/patch.html#generation make patchcheck] pass?
# Does the documentation [http://docs.python.org/devguide/documenting.html#building-the-documentation build without errors]? In general, building just the HTML docs is sufficient.
# Does the resulting HTML look reasonable? (For example: is the code formatted correctly, do the footnote links work)
== Finding tickets to triage ==
| |||