Anonymous user
Triaging Python tickets: Difference between revisions
no edit summary
imported>Jesstess No edit summary |
imported>Jesstess No edit summary |
||
Line 50:
In most cases, code changes must be accompanied by tests before they will get merged.
=== Example patch review ===
<blockquote>
jesstess, thanks for your patch and tests!<br />
<br />
The docstring for <code>parse_request</code> needs to be updated as part of this changes.<br />
<br />
Other than that, the patch looks correct from my inspection, applies cleanly, and implements a straightforward solution.<br />
<br />
I verified that with the patch applied, the reproducer no longer raises a <code>ValueError</code> and instead prints <code>42</code> as expected. <code>make patchcheck</code> also reports no errors, and the <code>test_httplib</code> tests still pass. I confirmed that the tests for parsing unicode strings that were added in this patch exercise the bug, as they fail with the code changes reverted and pass with the full patch applied.<br />
<br />
After the docstring is updated, I think this is ready for a commit review!
</blockquote>
== Reviewing documentation patches ==
| |||