Anonymous user
Triaging Python tickets: Difference between revisions
no edit summary
imported>Jesstess No edit summary |
imported>Jesstess No edit summary |
||
Line 64:
## If the patch includes tests, verify that the tests fail with the code changes reverted.
# Does [http://docs.python.org/devguide/patch.html#generation make patchcheck] pass?
# Is the patch accompanied by [http://docs.python.org/devguide/runtests.html new tests] that either exercise the bug or the new functionality?▼
# Do the tests impacted by the patch still pass? (The committer will run the whole test suite, but you can [http://docs.python.org/devguide/runtests.html#runtests run just the relevant tests])
# If functionality was added or changed, is the patch accompanied by new or updated [http://docs.python.org/devguide/documenting.html documentation]?
▲# Is the patch accompanied by new tests that either exercise the bug or the new functionality?
=== Example patch review ===
| |||