Anonymous user
How we handle patches (mmoved): Difference between revisions
no edit summary
imported>Jesstess No edit summary |
imported>Jesstess No edit summary |
||
Line 3:
== As a patch submitter ==
=== Before creating a patch series: ===
# Add unit tests with your functionality changes or additions.
** If you generate patches and attach them, please do a few local commits and create the patch series with "git format-patch". (Read about [[How to generate patches with git format-patch]])▼
# Test your changes on a local instance of the website. Prove to yourself that your changes address the issue they are supposed to address.
# Run the test suite, and make sure your unit tests pass and all tests that passed before your changes still pass.
# Use a tool like [http://pypi.python.org/pypi/PyChecker/0.8.12 PyChecker] to check for bugs.
=== While creating a patch series: ===
# Before creating the patch, update the master branch of your local repository checkout, and make sure your commits apply cleanly on top of master. In git, you can achieve this by developing on a branch and rebasing your branch commits on top of master.
▲
=== Submitting your patch series for review: ===
# Attach your patches to the issue ticket at https://openhatch.org/bugs.
# Change the issue status to "in-review".
# Join IRC and say that you have an issue ready for review.
If the reviewer says it's ready to go, your patch set will get deployed in short order. If the reviewer has feedback he/she wants addressed, make the necessary revisions and start back at the "Before creating a patch series" section.
== As a patch reviewer ==
# Review the patch series for correctness and cleanliness.
# If you are satisfied with the patch set:
## Have someone with deployment access deploy the changes and monitor the deployment.
# If you have revisions you'd like to see made, change the issue status to "in-progress", re-assign the issue to the patch submitter if it isn't already, and leave your review feedback on the ticket.
|